Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version compatibility matrix against CAPI and k8s #243

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

sflxn
Copy link

@sflxn sflxn commented Mar 29, 2019

Added 3 tables showing a version compatibility matrix against CAPI (main cluster
API), Kubernetes, and OSes. Currently, these were gathered manually.

Resolves #222

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2019
@sflxn
Copy link
Author

sflxn commented Mar 29, 2019

/hold till comments are complete

README.md Outdated
| --- | --- |
| 0.1 | gcr.io/cnx-cluster-api/vsphere-cluster-api-provider:v0.1 |
| 0.2 | gcr.io/cnx-cluster-api/vsphere-cluster-api-provider:0.2 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.2? or v0.1 -> 0.1, i am not sure, should be consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be consistent across providers, at the very least consistent across our releases.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@frapposelli frapposelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

README.md Show resolved Hide resolved
@frapposelli
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2019
@sflxn sflxn changed the title Add version support matrix against CAPI and k8s Add version compatibility matrix against CAPI and k8s Mar 29, 2019
@frapposelli
Copy link
Member

/lgtm
/approve

feel free to cancel the hold once you're ready

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli, sflxn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

README.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2019
@figo
Copy link
Contributor

figo commented Mar 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2019
README.md Outdated Show resolved Hide resolved
Added 3 tables showing a version compatibility matrix against CAPI (main cluster
API), Kubernetes, and OSes.  Currently, these were gathered manually.

Resolves kubernetes-sigs#222
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2019
@sidharthsurana
Copy link
Contributor

/lgtm

Thanks for this doc update @sflxn 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2019
@sflxn
Copy link
Author

sflxn commented Mar 29, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit e1a0555 into kubernetes-sigs:master Mar 29, 2019
jayunit100 pushed a commit to jayunit100/cluster-api-provider-vsphere that referenced this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants